Skip to content

feature/draft: 드래프트 웹소켓 dto수정 - #135

Merged
hwichoi0317 merged 1 commit into
devfrom
feature/draft
Aug 22, 2025
Merged

feature/draft: 드래프트 웹소켓 dto수정#135
hwichoi0317 merged 1 commit into
devfrom
feature/draft

Conversation

@hwichoi0317

@hwichoi0317 hwichoi0317 commented Aug 22, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • 신규 기능
    • 드래프트 진행 및 무작위 지명 알림에 참가자 이름이 함께 표시됩니다.
    • 실시간 업데이트와 기록 화면에서 지명한 사용자를 이름으로 식별할 수 있어 가독성과 추적성이 향상됩니다.
    • 알림/피드 항목에 사용자 이름이 포함되어 팀 구성 변화를 쉽게 파악할 수 있습니다.

@coderabbitai

coderabbitai Bot commented Aug 22, 2025 •
edited
Loading

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

DraftRequest DTO에 userName 필드가 추가되었고, DraftService에서 selectPlayer와 selectRandomPlayer 실행 시 Participant의 이름을 DraftRequest.userName에 설정하여 퍼블리시되는 메시지 페이로드에 포함되도록 수정되었습니다.

Changes

Cohort / File(s) Summary of Changes
DTO 확장 (userName 추가)
backendProject/src/main/java/likelion/mlb/backendProject/domain/draft/dto/DraftRequest.java		 DraftRequest에 private String userName 필드 추가. Lombok 기반 접근자/생성자/빌더에 필드 반영. 직렬화 페이로드에 이름 포함 가능.
서비스 페이로드 보강
backendProject/src/main/java/likelion/mlb/backendProject/domain/draft/service/DraftService.java		 selectPlayer, selectRandomPlayer에서 조회한 사용자 이름을 draftRequest.setUserName(user.getName())으로 설정하여 퍼블리시 전 페이로드에 포함. 제어 흐름 변화 없음.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Client
  participant Controller
  participant DraftService
  participant ParticipantRepo as ParticipantRepository
  participant Redis as Redis Pub/Sub

  Client->>Controller: 선수 선정/랜덤 선정 요청
  Controller->>DraftService: DraftRequest 전달
  DraftService->>ParticipantRepo: participantId로 사용자 조회
  ParticipantRepo-->>DraftService: Participant(name 등)
  Note right of DraftService: DraftRequest.userName = Participant.name 설정
  DraftService->>Redis: DraftRequest 퍼블리시 (userName 포함)
  Redis-->>Client: 구독자에게 업데이트 브로드캐스트
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

깡총—이름도 함께 날아가네,
드래프트 소식에 살포시 실려가네.
카드엔 아이디, 이제 이름까지 콕!
레디스 바람 타고 톡톡톡—
당근 들고 축하해요, 완성된 한 묶음 🥕

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between be9080b and 00e13d9.

📒 Files selected for processing (2)
  • backendProject/src/main/java/likelion/mlb/backendProject/domain/draft/dto/DraftRequest.java (1 hunks)
  • backendProject/src/main/java/likelion/mlb/backendProject/domain/draft/service/DraftService.java (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/draft

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hwichoi0317
hwichoi0317 merged commit c6d3968 into dev Aug 22, 2025
1 check was pending
@hwichoi0317
hwichoi0317 deleted the feature/draft branch August 22, 2025 06:52
This was referenced Aug 23, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hwichoi0317